Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Service user persistence #1665

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat: Service user persistence #1665

merged 2 commits into from
Jan 17, 2025

Conversation

arthurpitman
Copy link
Contributor

@arthurpitman arthurpitman commented Jan 8, 2025 •
edited
Loading

This PR adds persistence for account service users.
While the service users feature is in development, enable MONACO_FEAT_SERVICE_USERS feature flag.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Unit Test Results

1 972 tests  +6   1 971 ✅ +6   54s ⏱️ ±0s
  135 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 1f2a495. ± Comparison against base commit 228ac11.

♻️ This comment has been updated with latest results.

@arthurpitman arthurpitman force-pushed the feat/service-user-persistence branch from e6ac2cf to 1d14c60 Compare January 10, 2025 15:11
@arthurpitman arthurpitman self-assigned this Jan 10, 2025
@arthurpitman arthurpitman added the run-iam-test Manually trigger Account Management E2E tests for PRs label Jan 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

E2E Test Results

1 files   -     3  1 suites   - 271   19m 39s ⏱️ - 3m 37s
2 tests  - 2 083  2 ✅  - 2 081  0 💤  - 2  0 ❌ ±0 
2 runs   - 2 235  2 ✅  - 2 233  0 💤  - 2  0 ❌ ±0 

Results for commit 1f2a495. ± Comparison against base commit 228ac11.

This pull request removes 2085 and adds 2 tests. Note that renamed tests count towards both. 
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_group
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_policy
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_user
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_FailsIfThereIsJustEmptyProjects
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_RemovesEscapeCharsAsV2AutoEscapes
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksIfNoDeleteYamlExists
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksOnFullConfiguration
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent
…

github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/account ‑ TestDeployAndDelete_AllResources
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/account ‑ TestIdempotenceOfDeployment

♻️ This comment has been updated with latest results.

@arthurpitman arthurpitman force-pushed the feat/service-user-persistence branch from 1d14c60 to fba8f56 Compare January 10, 2025 15:26
@arthurpitman arthurpitman marked this pull request as ready for review January 10, 2025 15:34
@arthurpitman arthurpitman requested a review from a team as a code owner January 10, 2025 15:34
@arthurpitman arthurpitman added run-iam-test Manually trigger Account Management E2E tests for PRs and removed run-iam-test Manually trigger Account Management E2E tests for PRs labels Jan 10, 2025
tomazpu
tomazpu previously approved these changes Jan 17, 2025
View reviewed changes
@arthurpitman arthurpitman force-pushed the feat/service-user-persistence branch from fba8f56 to baf366a Compare January 17, 2025 14:40
@arthurpitman arthurpitman force-pushed the feat/service-user-persistence branch from baf366a to 1f2a495 Compare January 17, 2025 14:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arthurpitman arthurpitman added run-iam-test Manually trigger Account Management E2E tests for PRs and removed run-iam-test Manually trigger Account Management E2E tests for PRs labels Jan 17, 2025
@arthurpitman arthurpitman merged commit a928904 into main Jan 17, 2025
22 checks passed
@arthurpitman arthurpitman deleted the feat/service-user-persistence branch January 17, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomazpu tomazpu tomazpu approved these changes

@jskelin jskelin jskelin approved these changes

Assignees

@arthurpitman arthurpitman

Labels
run-iam-test Manually trigger Account Management E2E tests for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthurpitman @jskelin @tomazpu